eventsource a thread safe close method

Currently, there are several issues with the library.

Close is not thread safe. the isStreamClosed cannot protect a gorouting sending to a panic panel. ref: #33
Socket leaks. If the server responds with a 404, the resp.Body.Close is not called.

The changes should not affect any existing users.

Mar 23 '18 06:03 iandyh

ping @donovanhide

Apr 02 '18 06:04 iandyh

@donovanhide Please have a look at the PR.

Apr 12 '18 03:04 iandyh

This is too big a change to accept without added unit tests that prove current behaviour is not subtly altered.

Apr 12 '18 09:04 donovanhide

It only changes the implementation of all the APIs not the API itself. So the existing test cases are exactly for that.

Sent from my iPhone

On Apr 12, 2018, at 18:34, Donovan Hide [email protected] wrote:

This is too big a change to accept without added unit tests that prove current behaviour is not subtly altered.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Apr 12 '18 14:04 iandyh