system-design-primer icon indicating copy to clipboard operation
system-design-primer copied to clipboard

Added white background to all images (#630)

Open bolshoytoster opened this issue 3 years ago • 4 comments

The images don’t work well in dark mode (#630), I added a white background to all .png files with imageMagick:

find -name '*.png' -exec convert {} -background white -alpha remove -alpha off {} \;

bolshoytoster avatar Dec 30 '21 22:12 bolshoytoster

@donnemartin Please merge the pr.

harsh-batheja avatar Jan 02 '22 18:01 harsh-batheja

@harsh-batheja I've changed the backgrounds to grey, as you suggested here. The images that already had a background have stayed white though.

bolshoytoster avatar Jan 19 '22 22:01 bolshoytoster

Can this be merged please? Having real difficulty reading the images with dark mode. Thanks

benjo456 avatar May 02 '22 20:05 benjo456

@benjo456 you could use my fork instead for now.

bolshoytoster avatar May 02 '22 22:05 bolshoytoster