saws icon indicating copy to clipboard operation
saws copied to clipboard

[WIP] Upgrade to prompt_toolkit 2.0

Open jonathanslenders opened this issue 7 years ago • 7 comments

TODO: check the ignore_case parameter.

jonathanslenders avatar Feb 15 '18 19:02 jonathanslenders

See also: https://github.com/jonathanslenders/python-prompt-toolkit/issues/568 and: https://github.com/jonathanslenders/python-prompt-toolkit/pull/446

jonathanslenders avatar Feb 15 '18 19:02 jonathanslenders

@jonathanslenders you might want to check #68. tl;dr, this project is deprecated in favor of aws-shell.

jeffbyrnes avatar Feb 20 '18 17:02 jeffbyrnes

OK. I'll see whether I can send a similar pull request to aws-shell. Thanks for the pointer!

jonathanslenders avatar Feb 20 '18 19:02 jonathanslenders

I don't agree with @jeffbyrnes here. aws-shell seems much more abandoned than this. Anyway, I just stumbled upon saws and found problems with this PR.

I've fixed them on my end with some minor changes - see #114

xorb0ss avatar Aug 05 '19 17:08 xorb0ss

I mean, it’s… not an opinion of mine; at the time I posted that, the maintainer of SAWS (@donnemartin) appeared to have decided to work with the aws-shell folks & merge the projects (per the issue I referenced).

The aws-shell project is also Officially Supported™ by AWS, so that seems like a good thing? Not that they’re doing very much of that.

But honestly, you’re right that SAWS has seen more activity; aws-shell hasn’t been updated since Sep 21, 2018, per its project repo. OSS is hard? 🤷‍♂

jeffbyrnes avatar Aug 05 '19 18:08 jeffbyrnes

My bad, I hadn't looked at #68. Personal preference too, but having used aws-shell, I prefer saws. Not sure why that is though :-)

xorb0ss avatar Aug 05 '19 19:08 xorb0ss

Going through old issues I’m in, and giving this one a bump to either merge, or close, since it’s > 1 yr old.

jeffbyrnes avatar Dec 20 '20 19:12 jeffbyrnes