interactive-coding-challenges icon indicating copy to clipboard operation
interactive-coding-challenges copied to clipboard

Added Dockerfile and docker-compose.yml

Open cheesesashimi opened this issue 7 years ago • 5 comments

For those who are unfamiliar with iPython and it's workflow, it can be a bit daunting if you just want to do some coding challenges, especially for new developers. With that in mind, I've provided a Dockerfile and docker-compose.yml to help get things up and running faster.

In most cases, users will just have to run $ docker-compose up and copy / paste the URL it provides to get up and running. I've included some additional context in the README.md file as well.

I hope others find this useful!

cheesesashimi avatar May 07 '17 17:05 cheesesashimi

That sound great

eamanu avatar May 07 '17 21:05 eamanu

Hi @cheesesashimi, this sounds great, thanks for the pull request!

Any docker users that could help with reviewing?

donnemartin avatar May 16 '17 04:05 donnemartin

@donnemartin sure :+1:

iabok avatar May 16 '17 05:05 iabok

Hi @cheesesashimi,

Great work!

I have some changes that you must add to realize a correct Merge. First, I had to install Docker, you should explain this steps, or link to a tutorial. Second, You should add into requeriments.txt the docker-py module, because I had to install this python module. Fourth, you have to warning that the process take it time, Are not there some solution that you not have to wait many time?

Finally I have this error:

...
Removing intermediate container 38d27d736b5d
Successfully built 63474fe46540
Successfully tagged interactivecodingchallenges_jupyter-challenge:latest
WARNING: Image for service jupyter-challenge was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Creating interactivecodingchallenges_jupyter-challenge_1 ... 
Creating interactivecodingchallenges_jupyter-challenge_1 ... done
Attaching to interactivecodingchallenges_jupyter-challenge_1
**jupyter-challenge_1  | [FATAL tini (7)] Executing child process '/notebook/start_notebook.sh' failed: 'No such file or directory'
interactivecodingchallenges_jupyter-challenge_1 exited with code 1**

@donnemartin I don't know if Docker is necessary for the project because this don't require a powerful continuous integration. Using Docker will add complexity unnecessary.

Regards!

eamanu avatar Sep 16 '17 04:09 eamanu

Hi @cheesesashimi, from my point of view the idea is fantastic because no one has to mess the local environment with that, but some points.

  • I am agree with @eamanu that some introduction about docker link could be useful
  • I was testing the repository with the image, and I would like to ask you if nose is installed by default in the base image? If it wasn't, you could add a run pip install nose command to do it.

marcraminv avatar Oct 19 '18 16:10 marcraminv