Donald Huang
Donald Huang
@mopemope really sorry we missed this earlier. It looks like `Name` has been added since your PR, but could you rebase? We still need `Driver` and `ExecDriver`
@divideandconquer Thanks for your contribution! do you have time to rebase this? we'd like this functionality, so if you don't have time I can take this over
:+1: for testing. I made some hacky tests in a PR at https://github.com/hoonmin/dockerclient/pull/1/files and they don't pass... any idea why?
you're right - I assumed that the JSON objects would be newline-separated but that's unfortunately not true. I'm working on a PR to fix this
@diptanu please take a look and see if this works for you ^ Parsing all of the json objects is pretty negligible compared to the network io, so I don't...
can you also add the new method to the interface in [interface.go](https://github.com/samalba/dockerclient/blob/master/interface.go) and to the mock in [mockclient/mock.go](https://github.com/samalba/dockerclient/blob/master/mockclient/mock.go)?
@pmorton @ehazlett #71 handles the 3 requests that pmorton listed above - could you take a look at it? it has slightly more complex logic, but it's been tested and...
agree, my understanding of convention is that `.json` _does not_ support comments and `.jsonc` _does_ support comments. It's unexpected (but convenient) that comments work in `turbo.json`, and editors will work...