GRNsight icon indicating copy to clipboard operation
GRNsight copied to clipboard

BIOL 388-discovered data export bug: all gene IDs need to be alphabetical on all worksheets

Open kdahlquist opened this issue 11 months ago • 2 comments

BIOL/MATH 388 are using GRNsight this week. Here is the first bug. When exporting data to an Excel workbook, all of the gene IDs need to be sorted alphabetically on all the sheets. They are alphabetical on the "production_rates" and "degradation_rates" sheets, but not on the others (network, network_weights, _log2_expression, and threshold_b). Note that the network and network_weights sheets need to be alphabetical top to bottom and left to right.

kdahlquist avatar Apr 08 '25 23:04 kdahlquist

Ideally the ordering can be done right at load time so that it just carries through all the way to export

The ordering appears to happen in certain tabs, so it will be worth looking at the existing export code to see if there is already some kind of sort call taking place that we should just move further up in the workflow

dondi avatar Apr 09 '25 15:04 dondi

Because this involves export code, @Amelie1253 and @MilkaZek have been assigned for coordination, with @ntran18 taking the lead

dondi avatar Apr 09 '25 16:04 dondi

I figured out the issue. The sort function is working. However, it sorts the gene id, not the gene's standard name.

ntran18 avatar Apr 24 '25 00:04 ntran18

This is PR #1196 which looks close to done pending some small internal code renames

dondi avatar Aug 27 '25 17:08 dondi

PR merged and waiting for review

ntran18 avatar Sep 09 '25 20:09 ntran18

This fix is not yet live on beta v7.2.6

kdahlquist avatar Sep 10 '25 20:09 kdahlquist

@dondi I saw PR is merged, but have we pulled it to beta yet?

ntran18 avatar Sep 10 '25 20:09 ntran18

This might require a deeper dive—I checked the actual beta code on the server, and it matches the code changes from the PR. So the code is definitely there

As one attempt at addressing this, I manually stopped/restarted the beta server. We can see if that has any effect

Also @ntran18 can you verify whether the sort is happening on a local copy of the latest beta? That can be how we start figuring out why the behavior does not seem to be manifesting

dondi avatar Sep 11 '25 17:09 dondi

@dondi yes, it works for my local copy of beta! However, when I try on GRNsight website, it still doesn't work. Not sure why this would happen

ntran18 avatar Sep 11 '25 21:09 ntran18

Confirmed to be working in beta v7.2.7 and closing.

kdahlquist avatar Sep 17 '25 16:09 kdahlquist