mock-webserver
mock-webserver copied to clipboard
donatj
Windows support
Hey @donatj,
I just got your v3wip branch, rebased, added minor updates and it's passing through the tests.
Very cool!
I'll need to poke and prod this later, I'm AFK for a couple days, but I'm excited to this.
No problem, I'm just helping another open source project that would like to run their tests under Windows 😁
I've just checked and I can confirm these updates worked for my use case.
Sorry for the delay in getting this merged. I really wanted to get PHP running on a Windows system and give it a try before hand.
After hamfisting my way through getting PHP going on Windows (you guys really configure PATH with a GUI?!) everything appears to work as expected.
Also, I just want to be sassy and add "why you wouldn't just use WSL is a mystery to me" 😆
Hmmph. Once I merged it, I'm getting a semi-consistent CI failure on PHP 5.5... Well that's no fun
you guys really configure PATH with a GUI?!
@donatj Windows got some new things, there's a Windows Server Core, which has no GUI, and the PowerShell. Before the introduction of PowerShell, I think you'd have to use the setx :)
why you wouldn't just use WSL is a mystery to me
I'm just helping another repo, but I think it makes sense to have a test against Windows, considering minor differences might break something (e.g. PHP_EOL) 🤔
CI failure on PHP 5.5
Let me know if you need a hand 😅
Also, if you're ok to release a "broken" package (considering that it wasn't working in Windows anyway, it's already an improvement), I'll use it in the other repository and clear one debt 😅