Donát Csikós

Results 174 comments of Donát Csikós

@ValeriuIonutIocsa @netmikey @mfussenegger @effad @gbu-censhare @enqueue @stefanrybacki @ptrussart I'm working on improving test sources separation. Would you mind trying https://github.com/gradle/gradle/pull/19310? Any feedback is appreciated. You can evaluate my changes by...

Yes, you can check out [my feature branch](https://github.com/gradle/gradle/tree/donat/eclipse%2Ftest-sources-and-deps-take-2) and build a local distribution with the following command: ./gradlew install -Pgradle_installPath=/path/to/dist

We've done improvements on the Eclipse test sources in the upcoming Gradle 7.5 release: https://github.com/gradle/gradle/pull/19310 Can someone here confirm that the changes resolve this issue? To that, you can use...

It might make sense to take another look.

I managed to add classpath entries by manually defining `plusConfigurations`: ``` afterEvaluate { eclipse { classpath { plusConfigurations = [configurations.debugUnitTestRuntimeClasspath] } } } ``` Of course, this is not a...

If you use the Gradle import wizard then this is the expected behavior. At the same time, if add the `.project` and `.classpath` file to your repository and use Eclipse's...

@HoldYourWaffle If I import the project with Gradle 4.4+ into Eclipse then the output is: ``` SOURCE: main,test SOURCE: test LIB: test LIB: test ``` The project contains the wrapper...

Can you update your sample project so that it contains your latest findings? Maybe the Eclipse Java9 support doesn't play nicely with the Buildship classpath customization.

Can you please provide a minimal reproducer project?

Hi! I had an initial look at the implementation and it's really promising. I'll add my full review soon. FYI I'm currently working on modernizing the Buildship build scripts: https://github.com/eclipse/buildship/pull/1163...