Donald Sharp

Results 276 comments of Donald Sharp

FRR2.0 is incredibly ancient at this point in time and in addition there have been numerous bfd fixes between that version and current version of FRR. I would highly recommend...

@eqvinox can you get back to this one? @mruprich David got sick for a few weeks and this one fell through the holes

yep it was wrong from the get go. Which is why I didn't notice it. Not sure why clang-format didn't fix it though.

When I run the new test under any type of load it fails badly: ``` ================================================================== short test summary info ================================================================== FAILED ospf6_ecmp_inter_area/test_h.py::test_ecmp_inter_area - AssertionError: 'r1' wrong number of route...

as a note when I run the test by itself or concurrently with itself it works fine. It's only when scale/load is placed on the system that causes it to...

If you are adding usage of iptables and it is not present you should skip the test on that platform. See the bgp_as_allow_in/test_bgp_as_allow_in.py script and look at setup_module and add...

@rwestphal you misunderstand the problem. In step 11 the interface is shutdown but the expected output still has the interface that was shutdown in it for nexthops as being usable....

@rwestphal -> Regardless over our disagreement on expected output of the test. HOW DO YOU EXPECT anyone to modify the test when something changes? Having a reference output for `step1`...

@rwestphal -> what happens if the test system is under load and isis spf is run thus causing the test to fail? As it stands now we just happen to...

and that is exactly my point @rwgbsd -> The tests at the above step are leaving the interface in the expected output. If the test system gets delayed, but isisd...