eddy icon indicating copy to clipboard operation
eddy copied to clipboard

use int compare when both version fields are ints

Open benprew opened this issue 7 months ago • 4 comments

Fixes #129

Previous and after my change Screenshot from 2025-05-08 20-12-12 Screenshot from 2025-05-08 20-12-46

benprew avatar May 10 '25 06:05 benprew

We should diligently adhere to the version comparison specification, as described on the Debian site, see https://www.debian.org/doc/debian-policy/ch-controlfields.html#version. It's not only about the upstream version split by . which you tried to implement, but also about epochs. I'm working on it, I will create a pull request to your code @benprew when I'm ready!

camilajenny avatar Jun 20 '25 09:06 camilajenny

@benprew Thank you for your effort contributing to this project. As it turns out, the version problem annoyed me as well. Let's improve it together. I created a pull request improving your solution, please let me know what you think! https://github.com/benprew/eddy/pull/1

camilajenny avatar Jun 20 '25 14:06 camilajenny

Update to support different debian version schemes, with tests! Thanks camilajenny!

benprew avatar Jul 07 '25 04:07 benprew

@donadigo Are you able to review this PR? Are you still supporting eddy?

Thanks

benprew avatar Jul 07 '25 04:07 benprew