BluetoothSerial icon indicating copy to clipboard operation
BluetoothSerial copied to clipboard

Fixed Android 13, added "fineLocation" option

Open giuseppelanzi opened this issue 1 year ago • 4 comments

I submit this PR in order to be able to fix the plugin for Android 12 and 13.

In addition I added a fineLocation option in the discover process. Some users reported that they find awkward to give location accesso in order to link to a bluetooth printer (sounds like a reasonable thing to say).

Hope it helps.

giuseppelanzi avatar Mar 30 '23 08:03 giuseppelanzi

@don Please merge these changes..otherwise we have do lot f manual work while generating apk ..

If you need to quickly add my forked code to a cordova project, you can add the plugin in cordova using cordova plugin add https://github.com/giuseppelanzi/BluetoothSerial#30f0d6d229dc76d6a24cc3f7f27b345d25c4f893 --nofetch.

giuseppelanzi avatar Apr 19 '23 07:04 giuseppelanzi

I was thinkng abount cloning this repo and adding to npm with another name. Don't want to mess with other developers but in the current state the plugin can't be used.

@don would it be ok for you?

giuseppelanzi avatar Apr 19 '23 07:04 giuseppelanzi

@don Please merge these changes..otherwise we have do lot f manual work while generating apk ..

If you need to quickly add my forked code to a cordova project, you can add the plugin in cordova using cordova plugin add https://github.com/giuseppelanzi/BluetoothSerial#30f0d6d229dc76d6a24cc3f7f27b345d25c4f893 --nofetch.

Thanks but i am using capacitor https://github.com/danielsogl/awesome-cordova-plugins currently i am replacing java code in the file which generates BluetoothSerial.java

lajith111 avatar Apr 19 '23 08:04 lajith111

Made another change. The requestPermissionCallback() go always with discoverUnpaired() and so if the users needs to give permission for another functionality (like simple scan or list of paired devices) the discovering is started anyway.

In my PR the application goes on with only the proper method.

@don I'm thinking on cloning the repo to registering it on npm. If I do, the open license will be respected and you will always be cited.

giuseppelanzi avatar Apr 30 '23 09:04 giuseppelanzi