don
Added pair/unpair
Thanks for the pull request.
You're using reflection for unpair since it's not a public method? Please ensure that this fails cleanly if unpair doesn't exist.
Can you make a few changes?
- Add brackets around all if statements, even those that are one line
- Add some documentation for pair and unpair in README.md
- I'd prefer if PIN wasn't a member variable
@stakutis, it would be also nice to had a documentation of the Pair/Unpair method into the README.md, with a little example.
Ok, I'll try to clean this up this weekend.
Chris Stakutis 978 764 3488 Twitter: @Stakutis
On Fri, Apr 17, 2015 at 6:42 PM, Evan Liomain [email protected] wrote:
@stakutis https://github.com/stakutis, it would be also nice to had a documentation of the Pair/Unpair method into the README.md, with a little example.
— Reply to this email directly or view it on GitHub https://github.com/don/BluetoothSerial/pull/114#issuecomment-94090519.
Actually, I have not, but should. I think Don wanted me to clean a few things up. Got distracted. Been working on consumer-robots lately (bluetooth controlled) and I'll need it to work with Android next (currently chrome app). Open Source project on github I created... if interested, look for "meaowmeaow" I'm trying to get more people to help with the vision of web-page controlled robots. More details here: http://www.meaowmeaow.com
Chris Stakutis 978 764 3488 Twitter: @Stakutis
On Fri, Jul 31, 2015 at 6:57 AM, jimutt [email protected] wrote:
@stakutis https://github.com/stakutis Have you done any more on this? I would love your pair and unpair functions to be included in the master branch as I find it extremely useful being able to use PIN code protected devices for security and convenience reasons.
— Reply to this email directly or view it on GitHub https://github.com/don/BluetoothSerial/pull/114#issuecomment-126652316.
@stakutis Oops, I somehow managed to remove my post. But at least you saw it before it was deleted.
Ah, okay. Well you should of course spend your time on what you think is best. I'm definitely going to check out your meaowmeaow-project! Personally I'm currently working on an autonomous navigation system for a USV. I had initially planned creating the control panel as a native Android app but I think I'll actually go with Cordova instead due to my laziness (haven't worked much with android earlier) and now I think I've manage to get the bluetooth communication to work as well. I'll be writing about the project on my blog (http://jimmyutterstrom.com).
Hi guys, this problem about pin seems to be important for BLE devices integration, as it is the enabled security in most of the boards as per avoiding direct connections. Have you worked this point out with setPin? Can you merge this branch inside current ble-central project? There is not any other supported plugin with this functionality, just to know if can have it added properly to ble-central or need to write an override of this plugins in our end. Thanks!
Hi amitgadole,
i don't think so... We are already working on boards without pin, adding pin as an attribute of the board... But have had issues when trying to connect in a pin protected board.
Regards Juanjo Raya Project manager www.imaginae.net
Avda Francesc Macià 30 Esc A 1er 1a
Sabadell (Barcelona) Tlf 93 537 74 44 [image: Facebook] http://www.facebook.com/pages/Imaginae-Solutions-InternetEcommerce/141782755888519 [image: Twitter] http://twitter.com/#%21/ImaginaeSol Skype: [image: Skype] imaginae
El jue., 26 sept. 2019 a las 6:38, amitgandole ([email protected]) escribió:
Hi, Is this request merged?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/don/BluetoothSerial/pull/114?email_source=notifications&email_token=AJK2KWHM6BZ7CCJLO75C3YTQLQ4C5A5CNFSM4A5ZZYQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UIBJA#issuecomment-535330980, or mute the thread https://github.com/notifications/unsubscribe-auth/AJK2KWALQMGRPKRW2W3ZJFLQLQ4C5ANCNFSM4A5ZZYQA .
@benallard So is that working for you? Are you able to pair on Ionic app with programmatically entering PIN? What was the problem in @stakutis code?
@amitgandole No, sadly, somehow the intent we're waiting on (ACTION_PAIRING_REQUEST) doesn't get triggered. @stakutis, did it ever worked ?
