leaflet-locatecontrol icon indicating copy to clipboard operation
leaflet-locatecontrol copied to clipboard

Changelog not updated since v0.70

Open piotr-cz opened this issue 3 years ago • 4 comments

Latest version in the changelog is v0.70, while latest tag is v0.76.

Please update it to reflect latest changes. Also consider publishing GitHub Releases to describe changes for each version.

Without change descriptions it's not clear what's been changed/ added/ removed how to adapt code and if it's worth updating.

Changes summary using GitHub compare:

  • https://github.com/domoritz/leaflet-locatecontrol/compare/v0.74.1...v0.75.0
  • https://github.com/domoritz/leaflet-locatecontrol/compare/v0.75.0...v0.76.0

piotr-cz avatar Nov 30 '21 09:11 piotr-cz

Ahh, I just forgot to edit the change log. Can you send a pull request to update it? I can review and merge.

domoritz avatar Nov 30 '21 14:11 domoritz

Changelog says

Here we document breaking changes.

I'd suggest to document all changes. For example #296 that was released in v0.75 may or may not be considered breaking, depending on how the package is integrated.

piotr-cz avatar Dec 01 '21 09:12 piotr-cz

6df3c2a78f506a83f08d6dad134839223f4570e1 is also a breaking change, since it prevents use by older browsers that don't support ES6 arrow functions and template strings.

I'm not saying this is a bad change, just that it's a breaking one that is worth mentioning in the changelog.

gravitystorm avatar Dec 01 '21 12:12 gravitystorm

I'd suggest to document all changes and mark breaking ones since this does project doesn't bump major versions on B/C

piotr-cz avatar Dec 01 '21 12:12 piotr-cz