FinancePy icon indicating copy to clipboard operation
FinancePy copied to clipboard

EquityVolSurfaceConstructionSVI.ipynb EquityVolSurface.check_calibration() too many arguments

Open JustiP3 opened this issue 8 months ago • 1 comments

In the notebook: https://github.com/domokane/FinancePy/blob/master/notebooks/market/volatility/EquityVolSurfaceConstructionSVI.ipynb

At this step: In [12]: equitySurface.check_calibration(False, tol)

The following error is generated: TypeError: EquityVolSurface.check_calibration() takes 2 positional arguments but 3 were given

If the instance method is called in this way, the error message is avoided: equitySurface.check_calibration(tol)

I believe the notebook needs to be updated

JustiP3 avatar May 08 '25 04:05 JustiP3

Hi - I will be back on this in a 3-4 weeks. If you need it sooner, consider implementing it yourself with a pull request. Thanks

domokane avatar May 22 '25 17:05 domokane