domo-node-sdk icon indicating copy to clipboard operation
domo-node-sdk copied to clipboard

signature changed for domo.streams.create

Open simllll opened this issue 8 years ago • 1 comments

Hello all, thanks for the great library. I've notived since v2.0 the signature for domo.streams.create has change from: domo.streams.create(dataset, updatemethod) to one parameter: domo.streams.create({dataSet: dataset, updateMethod: 'REPLACE'})

just a heads up if anyone else runs into this.

regards Simon

simllll avatar Sep 06 '17 09:09 simllll

Thanks @simllll, this was one of a few breaking changes to v2. It was done as part of the move to Typescript.

https://github.com/domoinc/domo-node-sdk/blob/master/src/streams/models.ts#L3

We tried to make sure the examples were updated accordingly. Hopefully, they helped and these breaking changes didn't cause you too much inconvenience.

https://github.com/domoinc/domo-node-sdk/blob/master/examples/Stream/create-stream.js

walexnelson avatar Sep 07 '17 16:09 walexnelson