Daniel Kraft

Results 206 comments of Daniel Kraft

I'm all for simplifying the code of course, so no objections. In any case, I think you should not call `name_show` itself (the RPC method), but factor out the underlying...

For reference, this was resolved on the RPC side in #238.

I'm not sure about this. While it certainly makes the flow a bit easier, `fundrawtransaction`'s main function is to choose coins using wallet logic, which is not trivial to do...

@JeremyRand Thanks for your feedback! I thought the point was to add the *name input*, not the name output? Because you need to add the name output anyway already when...

@yanmaani The reason is fee computation and upstream https://github.com/bitcoin/bitcoin/issues/7879. If we can get upstream to solve this, I would be very happy myself, but I doubt it. What one can...

@JeremyRand Yes indeed, I think the data should be present in PSBTs. I do not know if `fundpsbt` works with imported addresses in Bitcoin Core - if you got some...

@JeremyRand I'm not aware of any other approach either, so yes, let's see what they think about that.

> If you want to do that then it'd make more sense to add a parameter to fundrawtransaction 'bytes', so that the fee is calculated for size+bytes (default value =...

Thanks for your suggestion! We've been thinking about this for a long time now, and even had a half-way working implementation in the past. I think our proposal was/is to...

I think the chain ID is not an issue. What we can do is just change the serialisation format of the auxpow to include the chain ID as well. In...