python-domino icon indicating copy to clipboard operation
python-domino copied to clipboard

[!166] Improve publish app

Open FouadApp opened this issue 1 year ago • 1 comments

What issue does this pull request solve?

The issue encountered is the inability to add essential parameters such as environmentId and externalVolumeMountIds in the method responsible for executing app_publish

What is the solution?

Add environmentId and externalVolumeMountIds

‘'' if unpublishRunningApps: self.app_unpublish() app_id = self._app_id if app_id is None: # No App Exists creating one app_id = self.__app_create(hardware_tier_id=hardwareTierId) url = self._routes.app_start(app_id) request = { "hardwareTierId": hardwareTierId, "environmentId": environmentId, "externalVolumeMountIds": externalVolumeMountIds } response = self.request_manager.post(url, json=request) return response ‘‘‘

Testing

  • [x] Unit test(s)

Pull Request Reminders

  • [x] Has the changelog been updated
  • [x] Has relevant documentation been updated?
  • [x] Does the code follow [Python Style Guide] (https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html)
  • [x] Are the existing unit tests still passing?
  • [ ] Have new unit tests been added to cover any changes to the code?
  • [ ] Has the JIRA ticket(s) been linked above?

References (optional)

FouadApp avatar Oct 02 '24 19:10 FouadApp

Hi @FouadApp, we are currently qualifying a Domino Standard Environment release candidate. After it is finalized we will accept this PR for the next release candidate! (It is likely a version bump will be required before merge.)

ddl-mmahmoud avatar Oct 09 '24 15:10 ddl-mmahmoud

hey @FouadApp , thanks for the contribution! I ended up porting your changes in #241 to avoid having you fix the conflicts (hope that's alright) - we'll cut a new version for the package soon with this change

ddl-s-rodriguez avatar Nov 14 '25 19:11 ddl-s-rodriguez