python-domino icon indicating copy to clipboard operation
python-domino copied to clipboard

BUG: in _validate_hardware_tier_id

Open dmbaker opened this issue 2 years ago • 4 comments

BUG!!!

This method is being passed a dict in the parameter hardware_tier_id, but the equality test expects a string!

1152 if hardware_tier_id == hardware_tier["hardwareTier"]["id"]: 1153 return True -> 1154 raise exceptions.HardwareTierNotFoundException( 1155 f"{hardware_tier_id} hardware tier Id not found" 1156 )

HardwareTierNotFoundException: {'value': 'small-k8s'} hardware tier Id not found

dmbaker avatar Jun 09 '23 15:06 dmbaker

Either pass a string, or on line 1152 to this:

1152 if hardware_tier_id['value'] == hardware_tier["hardwareTier"]["id"]:

dmbaker avatar Jun 09 '23 15:06 dmbaker

@dmbaker could you please clarify, which line of code sends hardware_tier_id as a dict and not as a string to _validate_hardware_tier_id method?

ddl-alexpanin avatar Jun 16 '23 00:06 ddl-alexpanin

@ddl-alexpanin, I have not been able to trace that. The error happens when I try to round trip the computeCluster value of a domino.job_status return as an argument compute_cluster_properties.

dmbaker avatar Jun 18 '23 11:06 dmbaker

Thanks @dmbaker! If you have a full stack trace with the error, not only the latest line, it will help a lot!

I will send these findings to our QE anyway.

ddl-alexpanin avatar Jun 19 '23 04:06 ddl-alexpanin