gotraceui icon indicating copy to clipboard operation
gotraceui copied to clipboard

Published 20 hours ago • verified publisher icon dominikh

Splitting stack span label on the period works poorly for generics

Open dominikh opened this issue 2 years ago • 1 comments

When a label like "honnef.co/go/foo.SomeType.SomeMethod" doesn't fit in the span, we split on . and display the last element, .SomeMethod in this example.

This works poorly for (at least) CPU samples in generic functions, as these may contain [...] in their name. For example, we have a span with the label honnef.co/go/gotraceui/mysync.Distribute[...] which gets truncated to .].

dominikh avatar Jul 24 '23 12:07 dominikh

I suppose it's too late to convince upstream to use a proper ellipsis instead?

whereswaldon avatar Jul 24 '23 15:07 whereswaldon