go-tools icon indicating copy to clipboard operation
go-tools copied to clipboard

SA1019: Fix missing deprecated fields in struct initialization

Open HeinKalido opened this issue 1 year ago • 6 comments

Addresses https://github.com/dominikh/go-tools/issues/607, For code like

ae.SD{
	D: "used",
}

It will print

 ae.SD.D is deprecated: external don't use me  (SA1019)

HeinKalido avatar Mar 11 '23 19:03 HeinKalido

Hey @HeinKalido, do you have any plan to try to get conflicts resolved? Otherwise, I could create a similar PR with conflicts resolved, and also add you as co-author for credits.

@dominikh any chance to get this reviewed and merged? (ofc, conflicts need to be solved, but beyond that?)

Thanks!

joanlopez avatar Jan 04 '24 19:01 joanlopez

@dominikh any chance to get this reviewed and merged? (ofc, conflicts need to be solved, but beyond that?)

Sure, once I have time to look at it.

dominikh avatar Jan 04 '24 20:01 dominikh

@joanlopez @dominikh I have applied the changes to the moved files.

Apologies for the delay.

HeinKalido avatar Jan 24 '24 15:01 HeinKalido

@joanlopez @dominikh I have applied the changes to the moved files.

Apologies for the delay.

Awesome! :) Thanks!

joanlopez avatar Jan 24 '24 17:01 joanlopez

Is there any active work on this PR right now? this is a pretty big gap in the usage of this linter right now

nicklipple avatar Jun 10 '24 20:06 nicklipple

I'll get around to merging it eventually.

dominikh avatar Jun 10 '24 20:06 dominikh