Dominik Honnef
Dominik Honnef
I'd be happy to prototype the necessary glue between Staticcheck patterns and such an Inspector API and benchmark its impact.
@adonovan Do you have any news on the relevant Inspector (or presumably Cursor) API?
In a strict sense you are right. But how realistic is this exact constellation of code, where you're (dynamically) interested in the field - existing - being unexported - having...
That's fair, but probably not something we can fix without either missing the majority of unused, unexported fields--by assuming that all use of reflection can lead to violations of the...
What benchmark in what package would I run to reproduce the numbers?
After rewriting QF1004 and SA4030 in terms of `Index.Calls`: ``` goos: linux goarch: amd64 pkg: golang.org/x/tools/gopls/internal/test/integration/bench cpu: AMD Ryzen 9 3950X 16-Core Processor │ baseline.txt │ rewritten.txt │ │ sec/op...
The referencing commits implement both 1 (at the package level, I didn't see how we'd do it at the file level) and 2 (for patterns that are rooted in CallExprs)....
As far as I am concerned, you can feel free to update to bbc2f4dd (current master)--I'm moderately sure no new bugs have snuck in, and it contains all the changes...
`parameters-are-used` is an experimental, unsupported option. The only valid use of `unused` currently is as used by `staticcheck`.
That said, this one might be easy enough to fix.