redmine_highlightjs Fix highlighting xml/html code by escaping html characters

Fix highlighting xml/html code by escaping html characters

Open anton-sergeev opened this issue 7 years ago • 4 comments

Here is bug, no escape html characters: redmine_highlightjs bug After fix: redmine_highlightjs fix

Mar 15 '17 08:03 anton-sergeev

This related to #18, #21, #26 Issues

Mar 15 '17 08:03 anton-sergeev

This is not a proper fix. You should check file extension and language given

Aug 16 '18 14:08 miloja

This is a common problem for html-like tags inside any language preformatted text. For example if I post the next:

<pre><code class="ruby">
some_string = "start <b>ddd</b>"
</code></pre>

I got the next result: redmine_highlightjs bug And with escaping suggested in this pull request: redmine_highlightjs with_fix

Aug 16 '18 21:08 anton-sergeev

You're right. The fix is very ok. I haven't thought about HTML hidden in ruby string constant. :)

Aug 17 '18 08:08 miloja