domfournier
domfournier
@santisoler See replies. I can do the mods depending on your answers.
@santisoler Changes made. Good for another round.
Side note, it looks like codecov is including the test files in its measure? Like coverage of the codebase by the tests + test files themselves?
Thought it would be mostly obvious since coverage requires the tests to run, but whatever. The decrease in coverage here is due to the new chunks under @pytest.mark.skip
Thanks for flagging this @ngodber . We are actively working on creating the i/o between geoh5 and omf v0.9.0 so users can export in either format. https://github.com/MiraGeoscience/omf/pull/7 We will PR...
Correct, the omf -> geoh5 is done, now working on the geoh5 -> omf. At least for the 5 objects that were supported in 0.9.0 (points, surface, curves, grid2D and...
@simpeg/simpeg-developers Ready for review gang.
The idea was to always ONLY deal with Scaled functions, so that we don't need to consistently check whether it is a scaled function or a combo. When evaluating `phi_d...
``` def __mul__(self, scalar): return ScaledObjectiveFunction(self.function, self.multiplier * scalar) ``` I like that, makes sense to not nest because of a multiplication.
re: `1- Adding an objective function to a combo, returns a new expanded combo` I really don't see the point of adding that complexity. We always want to scale the...