releaser icon indicating copy to clipboard operation
releaser copied to clipboard

Disable automatic haddock upload on stack

Open maralorn opened this issue 5 years ago • 4 comments

While cabal has a "--haddocks-for-hackage" flag, stack does not. This is an open issue since 2015.

See: https://github.com/commercialhaskell/stack/issues/737

It would probably be easy to implement this in releaser, but that is out of scope for this commit.

This commit adds also a very rudimentary detectBuildSystem utility. It might become useful in general.

This addresses the discussion from issue #10.

maralorn avatar May 04 '20 11:05 maralorn

I'm not sure this is the best approach since many projects ship with stack.yaml and cabal, so developer can pick either.

A better approach would be #16 in form of a question (do you want to upload haddock? [y/n]) together with an existing retry mechanism.

What do you think?

domenkozar avatar May 04 '20 14:05 domenkozar

Yeah, sure. Sounds nice. I just wanted to offer a fix for the problem I caused.

Not sure if I can come around to that other approach though. I am not sure how exactly it would look.

maralorn avatar May 04 '20 15:05 maralorn

Sorry if it sounded like you should fix this. I'll give it a go eventually.

domenkozar avatar May 04 '20 15:05 domenkozar

No. It didn‘t. I just didn‘t want to seem like on of those entitled open source users who cannot appreciate what you do for them. ;-)

maralorn avatar May 04 '20 16:05 maralorn