especially icon indicating copy to clipboard operation
especially copied to clipboard

Add ArraySpeciesCreate, Construct, IsArray and IsInteger abstract operations; Fix %String% intrinsic; Update @@species to return existing `Symbol.species` when available; Bump engine requirement; Add missing semicolons; Update readme

Open UltCombo opened this issue 9 years ago • 4 comments
trafficstars

TODO:

  • [ ] Write tests

I'm submitting these additions early so you can check whether the approach and style are appropriate.

@domenic By the way, do you prefer (and have time) to review each change before merging, or would you prefer a "commit first, ask questions later" strategy?

UltCombo avatar Dec 03 '15 04:12 UltCombo

Looks like I got a bit carried away fixing some nits in the process. Let me know if you would prefer to have split commits or PRs for those.

UltCombo avatar Dec 03 '15 05:12 UltCombo

Hey, this LGTM. Feel free to commit first, ask questions later :). Same with the other PR.

domenic avatar Dec 07 '15 16:12 domenic

Thanks. :smile_cat:

UltCombo avatar Dec 07 '15 17:12 UltCombo

I'll write the tests before merging, I'd feel bad lowering a project's code coverage.

UltCombo avatar Dec 07 '15 17:12 UltCombo