Dominic Cleal

Results 31 comments of Dominic Cleal

Why remove it entirely, is it causing a problem or warning? I'm curious why MD5 is OK if SHA1 needs to be removed.

Sure, I'm aware of the issues with SHA-1 but older distros or clients may still use it, so I was trying to ascertain why it needs to be removed (and...

I'd like to switch the RPMs in Fedora to point at a well-maintained fork too, rather than carrying the patches above (and also #69). I'd be happy to help with...

@mattock thanks, all received. It might be good to enable issues on that repo so we have somewhere to discuss things. I opened a PR for the date/valid-until fix discussed...

Looks like EPEL7 was missing a dpkg build, so freight hadn't been pushed (due to the RPM dep). I've requested the dpkg maintainer build + publish it, then I can...

Thanks for the reminder. I've built it again in EPEL, fixed a bug and the update is now here: https://admin.fedoraproject.org/updates/freight-0.3.5-6.el7 It'll be published in the epel-testing repo in a few...

Good catch, I fixed a couple more too. I'll try and write a reusable patch to submit to this repo soon, probably reusing the libdir from the Makefile somehow. Resubmitted...

The timestamps are ignored by default, but you could track them by configuring `ignored_attributes`: https://github.com/collectiveidea/audited/blob/3057aecc8854df928d9a46de75fd99c77e7a5038/lib/audited.rb#L21 is the default list. e.g. in a Rails initialiser: ```ruby Audited.ignored_attributes = %w(lock_version) ```

Thinking out loud about solutions, it might be that this needs to be configured as a string (which we call `constantize` on later) or as a lambda/something more dynamic.

> There is some discussion about a similar notice [here](https://github.com/rails/rails/issues/36363). The suggestion here's to move it into `lib/` and `require` it so it doesn't get auto-reloaded. That's a good workaround,...