cordova-plugin-photos icon indicating copy to clipboard operation
cordova-plugin-photos copied to clipboard

Ask for contributing

Open jguyet opened this issue 5 years ago • 3 comments

This is not a report issues. Hello developpers of cordova-plugin-photos.

I am Jérémy im developper for canal+ in France. I have forked your project for fix differents bugs and remove differents callbacks unused. If possible i want contribute in your project library with your rules for sure.

Contact me [email protected]

Good day !

jguyet avatar Apr 16 '20 11:04 jguyet

Hi Jeremy

Just make a pull request in GitHub. I’ll verify and apply or reject with comments. Anyway, thank you for your contributions!

— Sincerely, Max

On Apr 16, 2020, at 07:53, jguyet [email protected] wrote:

This is not a report issues. Hello developpers of cordova-plugin-photos.

I am Jérémy im developper for canal+ in France. I have forked your project for fix differents bugs and remove differents callbacks unused. If possible i want contribute in your project library with your rules for sure.

Contact me [email protected]

Good day !

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

domax avatar Apr 16 '20 12:04 domax

Hello everyone, this code

Photos.image(photo.ID,
    function(data) {
       console.log(data)
    },
    function(error) {
        console.error("Error: " + error);
    });

with the proper photo.id return by this code

Photos.photos( 
    function(photos) {
        console.log(photos);
    },
    function(error) {
        console.error("Error: " + error);
    });

does not works, i've this error Photo ID is undefined @jguyet even with your fork i've the same error

ishigo1987 avatar Apr 27 '20 12:04 ishigo1987

@ishigo1987 Why photo.ID? Object's properties in JS are case-sensitive. If you retrieved a photo object by Photos.image() function then you have to address image ID as photo.id.

domax avatar May 05 '20 22:05 domax