Swashbuckle.AspNetCore icon indicating copy to clipboard operation
Swashbuckle.AspNetCore copied to clipboard

[Bug]: attributes are moved to allOf instead of in the root of an object after updating from 6.5.0 to 6.6.2

Open DerGary opened this issue 1 year ago • 5 comments

Describe the bug

The left side is generated through swagger cli with version 6.5.0 of the library, and the right sight is generated after updating to 6.6.2: image When this is now used to generate a client from it it contains the following properties: image

Expected behavior

Left Side

Actual behavior

Right Side

Steps to reproduce

Create an empty type that inherits from a base class. We are using UseOneOfForPolymorphism as well as:

[SwaggerDiscriminator(ConnectionType.TypeDiscriminatorPropertyName)]
[SwaggerSubType(typeof(HttpConnectionConfigDto), DiscriminatorValue = ConnectionType.Http)]

Exception(s) (if any)

No response

Swashbuckle.AspNetCore version

6.6.2

.NET Version

net8.0

Anything else?

No response

DerGary avatar Jun 28 '24 13:06 DerGary

We don't explicitly write out the JSON, we delegate it to Microsoft.OpenApi. That dependency was updated to the latest release (1.6.14) as part of the 6.6.x release (#2795), so I would have thought that if this is a bug, it should be logged there.

martincostello avatar Jun 28 '24 13:06 martincostello

Okay, is there anything that I need to do?

DerGary avatar Jun 28 '24 13:06 DerGary

I would suggest opening an issue in their repo.

martincostello avatar Jun 28 '24 13:06 martincostello

Turns out it's now the expected behavior: #2268

serhiiz avatar Jul 11 '24 16:07 serhiiz

This issue is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further updates are made.

github-actions[bot] avatar Sep 10 '24 01:09 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Sep 24 '24 02:09 github-actions[bot]