Swashbuckle.AspNetCore icon indicating copy to clipboard operation
Swashbuckle.AspNetCore copied to clipboard

Fix that XML comment examples do not show up if the type is string and the example contains quotation marks

Open dldl-cmd opened this issue 1 year ago • 4 comments

Fix that XML comment examples do not show up if the type is string and the example contains quotation marks

Resolves #2088

dldl-cmd avatar Oct 13 '23 19:10 dldl-cmd

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI.

martincostello avatar Apr 13 '24 08:04 martincostello

@dldl-cmd Does this happen to fix general issues with example parsing, such as backslashes in the string leading to the example being omitted completely? EDIT: Nevermind, saw the example post, it clearly does.

S-Tasker avatar Apr 15 '24 11:04 S-Tasker

@martincostello It looks like the expected CI builds didn't run here - they're awaiting approval.

S-Tasker avatar Apr 19 '24 08:04 S-Tasker

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.39%. Comparing base (42e6876) to head (7989435).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2727      +/-   ##
==========================================
- Coverage   92.40%   92.39%   -0.02%     
==========================================
  Files          93       94       +1     
  Lines        3174     3167       -7     
  Branches      558      555       -3     
==========================================
- Hits         2933     2926       -7     
  Misses        241      241              
Flag Coverage Δ
Linux 92.39% <100.00%> (-0.02%) :arrow_down:
Windows 92.39% <100.00%> (+2.28%) :arrow_up:
macOS 92.39% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 19 '24 08:04 codecov-commenter

Is this something that mind find its way into v6.6 by any chance?

S-Tasker avatar May 06 '24 05:05 S-Tasker