Dominik Picheta comments

Results 594 comments of


                                            Dominik Picheta

The "isclosed" function from asyncnet lib does not detect when the client closes the connection to the server.

We should probably improve the docs for the `isClosed` proc. But I don't think it's up to sockets to track this: you need to track whether the socket is opened...

Nim tries to resolve generic field type name even though when condition is false

Hrm, could this be the same as #4797?

Given proc and type from two different modules named the same thing, Nim prefers the type

This is a bug, but please follow NEP1, it's there for a reason.

Add TFT_eSPI_ESP32_C6.c and TFT_eSPI_ESP32_C6.h

This seems like a pretty simple patch, any chance it could be merged in?

[RFC] Better Future

Thank you for making this list. I am happy with most of your proposed changes although I do have some reservations/questions: > deprecate Future.complete, as it prevents some optimizations and...

[RFC] Better Future

I once thought that exceptions could be used for future cancellation, but I no longer think that is possible. So yeah, I haven't come up with any other ideas for...

[RFC] Better Future

> Future should represent value that may be available in future. In this view it doesn't make sense to 'complete' it. Of course, it's just aesthetic opinion. Perhaps I misunderstood,...

Adds implicit rule for vendor/** in Python Workers.

Hmm, test failure doesn't seem related to my change: > TEST_CLOUDFLARE_API_TOKEN must be set

Embedded JDK ignores system cacerts

I ran into this on macOS. After installing `java` via `brew install java`, then Java proper (using the .dmg from https://www.java.com/en/download/), it started to work.

FIX SHOULD_GATE_ENTROPY condition

For context, while testing package memory snapshots I ran into two issues: * when tracing is enabled, which it is every time you use crossbow, the entropy code crashes the...