Dominik Picheta comments

Results 594 comments of


                                            Dominik Picheta

Too verbose by default

Ahh, seems Jester sets the log level: https://github.com/dom96/jester/blob/master/jester.nim#L455 Happy to accept a PR that changes this I guess

Adding support for "plugins" to Jester

Thanks for working on this @JohnAD. I currently don't have enough time to review your PR which I assume will require quite a bit of time, just want to let...

Nimsuggest warning on `routes`: 'cb' is not GC-safe as it accesses 'nameIterVar' which is a global using GC'ed memory [GcUnsafe2] jester.routes: proc (body: stmt): stmt{.noSideEffect, gcsafe, locks: <unknown>.}

Fixed?

Logging helpers

I suppose I should implement some logging formatting settings.

MultiData parsing boundary issue

Any chance you can create a repro code sample?

Files are not streamed, loaded directly into memory

It should get streamed though: https://github.com/dom96/jester/blob/master/jester.nim#L203. Perhaps it's a leak in Nim's GC/stdlib.

Files are not streamed, loaded directly into memory

The code immediately below the line you've quoted reads from the file stream. The `readToStream` operation isn't awaited so it does it's thing concurrently. Note that the async future streams...

Files are not streamed, loaded directly into memory

Yeah, I think you're right. That might be the problem here.

thisDir != projectDir as of Nimble 0.13.0.

Sorry about the breakage, although it's possible this was intentional (you might be able to find the commit responsible quite easily which should explain things)

`nimble install --retry:N` for network commands that can fail

This sounds like it can be implemented fairly easily. But thinking about it some more, the challenge with this is how we execute processes. AFAIK we block on their execution...