choosenim icon indicating copy to clipboard operation
choosenim copied to clipboard

1.4.4, broken install, wrong URL

Open juancarlospaco opened this issue 5 years ago • 4 comments

PS C:\Users\user> .\choosenim-0.7.4_windows_amd64.exe update self
   Updating choosenim
      Info: Already up to date at version 0.7.4

PS C:\Users\user> .\choosenim-0.7.4_windows_amd64.exe --yes --verbose --noColor --debug --firstInstall stable

     Debug: Reporting to analytics...
       Http Requesting http://nim-lang.org/channels/stable
Downloading Nim 1.4.4 from nim-lang.org
       GET: http://nim-lang.org/download/nim-1.4.4_x8.zip
[#                                                 ] 0mb 0kb/s

      Info: Couldn't download file from http://nim-lang.org/download/nim-1.4.4_x8.zip.

        ... Response was: 404 Not Found
     Debug: Reporting to analytics...
      Info: Binary build unavailable, building from source

       GET: http://nim-lang.org/download/nim-1.4.4.tar.xz

[##################################################] 100.0% 0kb/s
     Debug: Reporting to analytics...
 Extracting nim-1.4.4.tar.xz
     Debug: Reporting to analytics...
   Building Nim 1.4.4
   Building koch
  Executing bin/nim.exe c koch
   Cleaning failed build
   Warning: Cleaning failed: The process cannot access the file because it is being used by another process.
        ... Additional info: "C:\\Users\\user\\.choosenim\\toolchains\\nim-1.4.4"
     Debug: Reporting to analytics...
     Debug: Reporting to analytics...
oserr.nim(94)            raiseOSError
Error: unhandled exception: The system cannot find the file specified.
Additional info: "Requested command not found: \'bin/nim.exe c koch\'. OS error:" [OSError]

PS C:\Users\user>
  • It tries to download from http://nim-lang.org/download/nim-1.4.4_x8.zip Notice the x8.zip ?.
  • But theres binary for Windows at https://nim-lang.org/download/nim-1.4.4_x64.zip
  • The "C:\\Users\\user\\.choosenim\" is all empty folders.
  • It says Reporting to analytics... like 6 ~ 8 times ?.
  • With just the --firstInstall option is the same.
  • Running on cmd.exe is the same.

juancarlospaco avatar Feb 24 '21 08:02 juancarlospaco

Weird that it failed the build.

But that's a separate issue. The first issue is that it gets the nightly filename incorrectly, the code for that is here: https://github.com/dom96/choosenim/blob/master/src/choosenimpkg/download.nim#L272

So this code must be broken: https://github.com/dom96/choosenim/blob/master/src/choosenimpkg/utils.nim#L91

dom96 avatar Feb 24 '21 20:02 dom96

If you think is too uncommon bug, then close it. I git cloned anyway. I just think that maybe the generated URL should have a test.

juancarlospaco avatar Feb 25 '21 15:02 juancarlospaco

If you think is too uncommon bug, then close it

isn't it likely to affect other users?

timotheecour avatar Feb 25 '21 18:02 timotheecour

I don't think it's uncommon, but I would appreciate your help in diagnosing the cause and maybe even coming up with a PR to fix it :)

dom96 avatar Feb 25 '21 23:02 dom96

This should be fixed now.

dom96 avatar Oct 22 '22 22:10 dom96