dolt icon indicating copy to clipboard operation
dolt copied to clipboard

Writes using branch reference syntax (ie. `<db>/<branch>`) should fail

Open zachmu opened this issue 2 years ago • 1 comments

Dolt's transaction logic assumes all changes are on a single branch, the currently checked out one for the session. But there's a loophole:

update `mydb/otherbranch`.mytable set foo = baz;

This behavior is undefined and won't work correctly on commit. These databases should be read-only in this context, and these writes should fail the same way they do on read-only databases.

zachmu avatar Sep 15 '22 16:09 zachmu

Maybe related? https://github.com/dolthub/dolt/issues/4925

jycor avatar Dec 08 '22 00:12 jycor

So this is fixed and replace by #5314

timsehn avatar Mar 03 '23 23:03 timsehn