dolt
dolt copied to clipboard
Feat/support aliyun oss store
support aliyun oss as backend store
@zachmu Hi, this PR is to add support for aliyun oss as backend store same as gcs and aws s3, dolt is an amazing project, and hope I can do some contribution for it.
Thanks for the contribution. We'll look at this today. I think @bheni wrote this code.
Looks pretty good. My only real issue here is that the environment variables limit the oss remotes that can be added. All oss CreateDB calls will use the same endpoint, key_id and key_secret.
@bheni yes, thanks for reviewing, you are right, because aliyun oss doesn't support config file with different profile, I would like to go with aws strategy that connect to oss with a config file with multiple profile configured, for example
[default]
endpoint=<endpoint>
accessKeyID=<id>
accessKeySecret=<secret>
[prod-profile]
endpoint=<endpoint>
accessKeyID=<id>
accessKeySecret=<secret>
the default credentials file will locate at $HOME/.oss/dolt_oss_credentials, environment variable will still be supported for container environment.
The priority order is environment variable > user provide profile > default profile
dolt remote add --oss-creds-profile prod-profile --oss-creds-config
what do you think?
@xujihui1985 I think that works. If customers show up and have issues with it we can look at other solutions.
ok, I'm working on it
@xujihui1985 I think that works. If customers show up and have issues with it we can look at other solutions. @bheni It's busy last week, I implement oss store with oss cred file config, please have a look
@bheni Hi bheni, would you like to take a look at this PR and give some advice?
LGTM. I can't really test out the oss specific code. If oss users have issues I'll reach out to you.
of course, I'm glad to be a part of this project, and I will continue to contribute to this project.
Running our tests. If it all passes, I'll merge and it'll go out in the next release. Thanks for the contribution!
Thank you for the contribution @xujihui1985!! 🙏 Very appreciated!
Test run looked good, so I went ahead and merged this in to main. This will go out with the next release of Dolt, later this week. 🎉