dolt icon indicating copy to clipboard operation
dolt copied to clipboard

Published 20 hours ago • verified publisher icon dolthub

Wire protocol engine test harness

Open zachmu opened this issue 2 years ago • 3 comments

https://github.com/dolthub/dolt/issues/3645 appears to only manifest over the wire.

We should proactively test for wire compatibility by writing a wire-protocol harness to the engine tests. It should start up a dolt server and talk to it over the local network.

zachmu avatar Jun 18 '22 02:06 zachmu

A recent GMS refactoring introduced some bugs that would have easily manifested in our test suite if we'd had an over-the-wire test harness.

  • https://github.com/dolthub/go-mysql-server/pull/1204

fulghum avatar Aug 22 '22 20:08 fulghum

Another bug with wire serialization that is difficult to catch without running tests over the wire:

  • https://github.com/dolthub/dolt/issues/4306

fulghum avatar Sep 12 '22 21:09 fulghum

Another bug that could have been caught by over-the-wire test harness:

  • https://github.com/dolthub/dolt/issues/4376

PavelSafronov avatar Oct 20 '22 19:10 PavelSafronov

Another Dolt bug that only appears through dolt sql-server and not through dolt sql that we could have caught with these tests:

  • https://github.com/dolthub/dolt/issues/6546

fulghum avatar Aug 21 '23 19:08 fulghum