dolt icon indicating copy to clipboard operation
dolt copied to clipboard

Stop Deserializing Geometry Addresses

Open jycor opened this issue 1 month ago • 5 comments

For some reason, the code implies there may be a mix up in the encodings of Geometry and GeometryEnc, I don't think this was ever the case?

jycor avatar Nov 21 '25 19:11 jycor

#benchmark

jycor avatar Nov 21 '25 19:11 jycor

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/19581894347

github-actions[bot] avatar Nov 21 '25 19:11 github-actions[bot]

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
277313a ok 5937471
version total_tests
277313a 5937471
correctness_percentage
100.0

coffeegoddd avatar Nov 21 '25 20:11 coffeegoddd

@jycor DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 63.32 63.32 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt d565cf29551c91b0bdcefac1c7e414b545da8f33 36.55 dolt 277313a6a3e08b4588b789e349404079791cbc9b 36.19 -0.98

coffeegoddd avatar Nov 21 '25 20:11 coffeegoddd

@jycor DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.55 0.55 0.0
groupby_scan 14.21 14.21 0.0
index_join 2.14 2.14 0.0
index_join_scan 1.37 1.34 -2.19
index_scan 24.38 24.38 0.0
oltp_point_select 0.28 0.28 0.0
oltp_read_only 5.28 5.28 0.0
select_random_points 0.58 0.59 1.72
select_random_ranges 0.57 0.57 0.0
table_scan 27.66 28.16 1.81
types_table_scan 81.48 81.48 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.55 6.55 0.0
oltp_insert 3.25 3.25 0.0
oltp_read_write 11.65 11.65 0.0
oltp_update_index 3.3 3.25 -1.52
oltp_update_non_index 3.19 3.19 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.91 6.91 0.0

coffeegoddd avatar Nov 21 '25 21:11 coffeegoddd