dolt icon indicating copy to clipboard operation
dolt copied to clipboard

Implement buffer for TupleBuilder

Open jycor opened this issue 1 month ago • 14 comments

If this works, remove BuffPool implementation with actual []byte buffer or a real sync.Pool

jycor avatar Nov 18 '25 00:11 jycor

#benchmark

jycor avatar Nov 18 '25 01:11 jycor

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/19450146827

github-actions[bot] avatar Nov 18 '25 01:11 github-actions[bot]

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6a304fb ok 5937471
version total_tests
6a304fb 5937471
correctness_percentage
100.0

coffeegoddd avatar Nov 18 '25 01:11 coffeegoddd

@jycor DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 63.32 63.32 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt b64ad086df2d989029c678c2b933031b6fe65451 37.24 dolt 6a304fb46806660f010aeac1752549c3ad469650 36.69 -1.48

coffeegoddd avatar Nov 18 '25 01:11 coffeegoddd

@jycor DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.55 0.55 0.0
groupby_scan 13.7 13.7 0.0
index_join 2.07 2.07 0.0
index_join_scan 1.32 1.34 1.52
index_scan 28.67 28.67 0.0
oltp_point_select 0.28 0.28 0.0
oltp_read_only 5.18 5.18 0.0
select_random_points 0.58 0.57 -1.72
select_random_ranges 0.57 0.57 0.0
table_scan 28.67 28.16 -1.78
types_table_scan 92.42 92.42 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.55 6.55 0.0
oltp_insert 3.19 3.25 1.88
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.25 3.25 0.0
oltp_update_non_index 3.19 3.19 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.91 6.91 0.0

coffeegoddd avatar Nov 18 '25 02:11 coffeegoddd

#benchmark

jycor avatar Nov 19 '25 00:11 jycor

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/19485332516

github-actions[bot] avatar Nov 19 '25 00:11 github-actions[bot]

@jycor DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 63.32 63.32 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt f6e9519711208597624d3e0ec2d54278bc6d5db7 36.56 dolt 166e1228583ad1aa5d93ef79713c1abac48a5691 35.98 -1.59

coffeegoddd avatar Nov 19 '25 01:11 coffeegoddd

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ab36245 ok 5937471
version total_tests
ab36245 5937471
correctness_percentage
100.0

coffeegoddd avatar Nov 19 '25 01:11 coffeegoddd

@jycor DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.57 0.56 -1.75
groupby_scan 13.95 14.21 1.86
index_join 2.07 2.07 0.0
index_join_scan 1.32 1.32 0.0
index_scan 29.19 29.19 0.0
oltp_point_select 0.28 0.28 0.0
oltp_read_only 5.18 5.18 0.0
select_random_points 0.58 0.59 1.72
select_random_ranges 0.57 0.57 0.0
table_scan 28.16 28.16 0.0
types_table_scan 94.1 94.1 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.55 6.55 0.0
oltp_insert 3.19 3.25 1.88
oltp_read_write 11.65 11.65 0.0
oltp_update_index 3.25 3.3 1.54
oltp_update_non_index 3.19 3.19 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.91 6.91 0.0

coffeegoddd avatar Nov 19 '25 01:11 coffeegoddd

#benchmark

jycor avatar Nov 19 '25 02:11 jycor

@jycor workflow run: https://github.com/dolthub/dolt/actions/runs/19487313064

github-actions[bot] avatar Nov 19 '25 02:11 github-actions[bot]

@jycor DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 63.32 64.47 1.82
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 256bfca6d97f94221f25589b7f9843003cbfd59f 36.97 dolt ab36245a8b1ed7b2e88b821a5741a3263a63cdf7 36.49 -1.3

coffeegoddd avatar Nov 19 '25 02:11 coffeegoddd

@jycor DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.57 0.56 -1.75
groupby_scan 13.7 13.95 1.82
index_join 2.03 2.07 1.97
index_join_scan 1.32 1.32 0.0
index_scan 29.19 29.19 0.0
oltp_point_select 0.28 0.28 0.0
oltp_read_only 5.18 5.18 0.0
select_random_points 0.57 0.59 3.51
select_random_ranges 0.57 0.57 0.0
table_scan 28.16 28.16 0.0
types_table_scan 94.1 92.42 -1.79
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.55 6.55 0.0
oltp_insert 3.19 3.25 1.88
oltp_read_write 11.65 11.65 0.0
oltp_update_index 3.3 3.3 0.0
oltp_update_non_index 3.19 3.19 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.91 6.91 0.0

coffeegoddd avatar Nov 19 '25 03:11 coffeegoddd