dolphin icon indicating copy to clipboard operation
dolphin copied to clipboard

WIP: WiimoteReal: Attempt to fix M+ detection problems.

Open jordan-woyak opened this issue 5 years ago • 5 comments

This is an attempt to fix: https://bugs.dolphin-emu.org/issues/7444

MotionPlus detection sometimes fails in Real Wii Remote mode for the same reason speaker data doesn't work well. Not enabling "sniff mode" keeps the remote in a 100hz (vs 200hz) input loop. MotionPlus initialization quickly cycles the extension port from connected->disconnected->connected. At 100hz that signal is sometimes missed.

This hack-fix requests two status reports when it sees a game send the M+ activation signal and overwrites the first response to show the "disconnected" state.

I can almost never reproduce this issue myself but having just dealt with M+ in PR #8575 I can see how a trick like this might be needed.

Here's one report that it works around the problem. Yay. https://www.reddit.com/r/DolphinEmulator/comments/iwa9h2/how_do_i_get_dolphin_to_recognize_motion_plus/

jordan-woyak avatar Feb 10 '20 21:02 jordan-woyak

Just curious, what issue is occurring with M+ detection?

iwubcode avatar Feb 11 '20 01:02 iwubcode

@iwubcode I'll update the PR description with some more info.

jordan-woyak avatar Feb 11 '20 01:02 jordan-woyak

Considering how simple this is, is there any reason not to merge it?

JMC47 avatar Oct 20 '22 18:10 JMC47

Considering how simple this is, is there any reason not to merge it?

I was hoping to get some better confirmations that it actually successfully works around the problem.

jordan-woyak avatar Oct 20 '22 18:10 jordan-woyak

I used to be able to reproduce the problem, I'll give it a go.

JMC47 avatar Oct 20 '22 18:10 JMC47

This PR is dead. It's very hacky and it didn't seem to help for people.

jordan-woyak avatar Mar 20 '24 19:03 jordan-woyak