dolphin-emu
Fix pkgconfig includedirs
See commit description, seems self explanatory; I'm not sure if it's the best solution.
Also I noticed that zlib doesn't link right with minizip-ng 4, but I'm still investigating.
re: issue with zlib on minizip-ng 4, it seems like the pkgconfig file was changed and cmake doesn't correctly pull in the zlib link dependency correctly. Perhaps moving it to find minizip-ng via cmake might fix the issue, but I don't have a patch available.
I don't think this is correct. Under modern cmake, the include dir should be attached to the imported target, and setting it as a dependency automatically forwards that include dir. If you have to resort to globally setting the include directory like this then someone in the dependency chain is either not declaring the dependency correctly or the include directory is not correctly attached to the target.
I don't think this is correct. Under modern cmake, the include dir should be attached to the imported target, and setting it as a dependency automatically forwards that include dir. If you have to resort to globally setting the include directory like this then someone in the dependency chain is either not declaring the dependency correctly or the include directory is not correctly attached to the target.
Yeah I thought so. Something is wrong in the chain, which is likely the cause of the zlib issue I'm seeing too.
You know maybe the cmake implementation of pkgconfig is either limited or buggy. I'm curious why pkgconfig is used for both zlib and minizip, when I believe both have cmake files included to find the system libs.