dolphin icon indicating copy to clipboard operation
dolphin copied to clipboard

Debugger MemoryWidget,: Move "Set value from file" to input combo box…

Open TryTwo opened this issue 3 years ago • 0 comments

…. Add valid address check before writing.

For the UI it's better as an input type. For coding, it's bit of an outlier, but doesn't require many changes. You need to click the Set Value button after selecting "Set value from file".

TryTwo avatar Jul 03 '22 16:07 TryTwo

FWIW I think this is not good from a UX perspective, I'd rather keep the separate button.

AdmiralCurtiss avatar Sep 03 '22 19:09 AdmiralCurtiss

it just seems like an infrequently used (but quite useful) feature for where the button is placed.

That and memory dumps feel more suitable as some kind of menu item more than buttons, but we don't have any menus.

TryTwo avatar Sep 03 '22 23:09 TryTwo

Yeah, a menu or something would be a much better place to put those buttons.

AdmiralCurtiss avatar Sep 03 '22 23:09 AdmiralCurtiss

I figured out how to add a mini menubar. Would this be desirable? If we wanted to add more sidebar widgets we could use a view menu to show/hide stuff.

menubar

TryTwo avatar Sep 06 '22 15:09 TryTwo

Yeah, I think that's much preferable to both the current state and the combo box in this PR.

AdmiralCurtiss avatar Sep 06 '22 20:09 AdmiralCurtiss