dolphin icon indicating copy to clipboard operation
dolphin copied to clipboard

Fixes for cmake shared library detection.

Open Zopolis4 opened this issue 2 years ago • 4 comments

These changes were originally going to be part of a series of changes that let dolphin build on ChromeOS, but then it...built. Anyways, these should make the cmake build steps a bit less noisy, now that it isint complaining about not having a Findfmt.cmake and hidapi can see FindLIBUDEV.cmake.

Most of the Find*.cmake files also need a bit of an overhaul, they're wildly inconsistent on capitalisation, indentation, ordering, naming, arguments, etc. I don't feel like I know enough about cmake or the coding styles, but I thought I'd put it out there. We should also have a FindQt.cmake, It'd remove the need for all the CMAKE_PREFIX_PATH nonsense and should make building on esoteric platforms or configurations much easier. Again, I don't know enough about cmake to confidently make one, just putting it out there.

Zopolis4 avatar May 29 '22 03:05 Zopolis4

Do ".cmake" files not need a legal header?

Rumi-Larry avatar May 30 '22 00:05 Rumi-Larry

Do ".cmake" files not need a legal header?

A bunch of them don't, it's a bit of a mess. I'm not sure, a couple of them that we presumably sourced from elsewhere don't.

Zopolis4 avatar May 30 '22 01:05 Zopolis4

👍no idea if the cmake changes are "good" but i've been seeing these warnings for a while and would be nice if they went away.

shuffle2 avatar Jun 03 '22 19:06 shuffle2

I've removed the findfmt.cmake due to conflicts with target importing.

Zopolis4 avatar Aug 05 '22 00:08 Zopolis4