dolphin icon indicating copy to clipboard operation
dolphin copied to clipboard

[ Needs Testing ] Vulkan: use Vulkan Memory Allocator for better memory handling

Open iwubcode opened this issue 3 years ago • 7 comments

I saw this in the PCSX2 merge by @stenzek , thought it might be nice to have in Dolphin too. Apparently many emulators are using it now (RPCS3 and PPSSPP also leverage this). See the website for details. Needs testing.

The second commit is the external. I temporarily included it to allow for compilation on all platforms / testing.

iwubcode avatar Jan 19 '22 00:01 iwubcode

Actually, I'll put the external in a second commit, so users can test before we decide to merge

iwubcode avatar Jan 19 '22 00:01 iwubcode

Hoping android vulkan backend improve :)

ghost avatar Jan 19 '22 00:01 ghost

Super Mario Galaxy regressed from 90 -> 70 fps and Double Dash from 190 -> 160 fps on my GTX 1060.

Miksel12 avatar Jan 21 '22 00:01 Miksel12

I pushed up some additional changes. Seems I now have similar performance levels (at least in my limited testing) as master but I was hoping for gains in either performance or memory. While vma provides a lot of functionality, I think to see gains using it would require more effort than I'm willing to give at this particular time. Closing for now!

iwubcode avatar Jan 21 '22 07:01 iwubcode

Why :(

ghost avatar Jan 21 '22 08:01 ghost

It was slower than what we currently use, and iwubcode doesn't ahve the time to make it faster.

JMC47 avatar Jan 21 '22 08:01 JMC47

It might be interesting to see how an updated VMA fares, this PR uses a very dated release (though it was the most up to date stable version at the time).

Miksel12 avatar Jul 27 '22 12:07 Miksel12

Kobin's PR is looking to supersede this. Going to close this out.

iwubcode avatar Oct 08 '22 00:10 iwubcode