dolphin icon indicating copy to clipboard operation
dolphin copied to clipboard

[WIP] Add timing hack to fix Splinter Cell: Chaos Theory and Speed Challenge.

Open JMC47 opened this issue 3 years ago • 4 comments

Dolphin's GPU timings are awful, and the GPU is way too fast especially in low polygon scenes. In order to rectify this, I readded the old timings we used before 4.0-5369, but only use it when there's very few vertices being rendered.

This needs heavy testing in order to make sure there aren't performance regressions or any other crashes. This is known to fix most Action Replay titles, both Advance Game Ports hanging, and Ubisoft's Speed Challenge. This is very likely to either break/fix fifo sensitive titles that have either regressed or been fixed by various things.

Code was initially an if/else, but JosJuice pointed out to me there was a much cleaner way to do it, resulting in this.

image

JMC47 avatar Nov 14 '21 23:11 JMC47

I've been testing these FIFOCI differences, and they are just that - fifoci differences. The actual games are all fine so far. I haven't tested every single one.

I will rerecord fifologs as needed though.

JMC47 avatar Nov 15 '21 00:11 JMC47

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • custom-brawl-char on ogl-lin-mesa: diff
  • DKCR-Char on ogl-lin-mesa: diff
  • inverted-depth-range on ogl-lin-mesa: diff
  • kirby-shadows on ogl-lin-mesa: diff
  • metroid-visor on ogl-lin-mesa: diff
  • mp3-bloom on ogl-lin-mesa: diff
  • my-word-coach on ogl-lin-mesa: diff
  • nfsu-reflections on ogl-lin-mesa: diff
  • pm-hc-jp on ogl-lin-mesa: diff
  • rs2-glass on ogl-lin-mesa: diff
  • rs2-skybox on ogl-lin-mesa: diff
  • rs2-zfreeze on ogl-lin-mesa: diff
  • sms-gc on ogl-lin-mesa: diff
  • soniccolors-mm on ogl-lin-mesa: diff
  • sw3-dt on ogl-lin-mesa: diff
  • custom-brawl-char on sw-lin-mesa: diff
  • DKCR-Char on sw-lin-mesa: diff
  • fortune-street-white-box on sw-lin-mesa: diff
  • inverted-depth-range on sw-lin-mesa: diff
  • kirby-shadows on sw-lin-mesa: diff
  • metroid-visor on sw-lin-mesa: diff
  • mkdd-efb on sw-lin-mesa: diff
  • my-word-coach on sw-lin-mesa: diff
  • nfsu-purplerect on sw-lin-mesa: diff
  • nfsu-reflections on sw-lin-mesa: diff
  • pm-hc-jp on sw-lin-mesa: diff
  • rs2-glass on sw-lin-mesa: diff
  • rs2-skybox on sw-lin-mesa: diff
  • smg2-fog on sw-lin-mesa: diff
  • sms-bubbles on sw-lin-mesa: diff
  • super-sluggers-white-out on sw-lin-mesa: diff
  • sw3-dt on sw-lin-mesa: diff
  • thps4-shadow on sw-lin-mesa: diff
  • tsp3-pinkgrass on sw-lin-mesa: diff
  • ztp-grass on sw-lin-mesa: diff
  • zww-water on sw-lin-mesa: diff
  • zww-waves on sw-lin-mesa: diff
  • custom-brawl-char on ogl-lin-radeon: diff
  • DKCR-Char on ogl-lin-radeon: diff
  • inverted-depth-range on ogl-lin-radeon: diff
  • kirby-shadows on ogl-lin-radeon: diff
  • metroid-visor on ogl-lin-radeon: diff
  • mp3-bloom on ogl-lin-radeon: diff
  • my-word-coach on ogl-lin-radeon: diff
  • nfsu-reflections on ogl-lin-radeon: diff
  • pm-hc-jp on ogl-lin-radeon: diff
  • rs2-glass on ogl-lin-radeon: diff
  • rs2-skybox on ogl-lin-radeon: diff
  • rs2-zfreeze on ogl-lin-radeon: diff
  • sms-gc on ogl-lin-radeon: diff
  • soniccolors-mm on ogl-lin-radeon: diff
  • sw3-dt on ogl-lin-radeon: diff
  • aeon-charge-attack on uberogl-lin-radeon: diff
  • burnout2-vehicletextures on uberogl-lin-radeon: diff
  • chibi-robo-fastdepth on uberogl-lin-radeon: diff
  • custom-brawl-char on uberogl-lin-radeon: diff
  • djhero2-blend on uberogl-lin-radeon: diff
  • DKCR-Char on uberogl-lin-radeon: diff
  • DKCR-fast-depth on uberogl-lin-radeon: diff
  • ed-updated on uberogl-lin-radeon: diff
  • fishing-resort-map on uberogl-lin-radeon: diff
  • fortune-street on uberogl-lin-radeon: diff
  • fortune-street-white-box on uberogl-lin-radeon: diff
  • f-zero-rain on uberogl-lin-radeon: diff
  • inverted-depth-range on uberogl-lin-radeon: diff
  • kirby-shadows on uberogl-lin-radeon: diff
  • last-story-shadows on uberogl-lin-radeon: diff
  • lego-star-wars-crane-shadow on uberogl-lin-radeon: diff
  • lm-mario-portrait on uberogl-lin-radeon: diff
  • luigi-shadows on uberogl-lin-radeon: diff
  • mario-baseball-shadows on uberogl-lin-radeon: diff
  • metroid-visor on uberogl-lin-radeon: diff
  • mkdd-efb on uberogl-lin-radeon: diff
  • monkeyball-fuse on uberogl-lin-radeon: diff
  • mp3-bloom on uberogl-lin-radeon: diff
  • mtennis-zfreeze on uberogl-lin-radeon: diff
  • my-word-coach on uberogl-lin-radeon: diff
  • nfsu-reflections on uberogl-lin-radeon: diff
  • nhl-slap on uberogl-lin-radeon: diff
  • pm-hc-jp on uberogl-lin-radeon: diff
  • rs2-glass on uberogl-lin-radeon: diff
  • rs2-skybox on uberogl-lin-radeon: diff
  • rs2-zfreeze on uberogl-lin-radeon: diff
  • rs3-bumpmapping on uberogl-lin-radeon: diff
  • sfa-shadows on uberogl-lin-radeon: diff
  • sf-assault-flashing on uberogl-lin-radeon: diff
  • smg2-fog on uberogl-lin-radeon: diff
  • smg-mmg on uberogl-lin-radeon: diff
  • smg-roar on uberogl-lin-radeon: diff
  • sms-bubbles on uberogl-lin-radeon: diff
  • sms-gc on uberogl-lin-radeon: diff
  • sms-water on uberogl-lin-radeon: diff
  • soniccolors-mm on uberogl-lin-radeon: diff
  • sonic-riders-zg-4p on uberogl-lin-radeon: diff
  • sw3-dt on uberogl-lin-radeon: diff
  • thps4-shadow on uberogl-lin-radeon: diff
  • tla-menu on uberogl-lin-radeon: diff
  • tos-invis-char on uberogl-lin-radeon: diff
  • tp-skin on uberogl-lin-radeon: diff
  • zww-armos on uberogl-lin-radeon: diff
  • zww-water on uberogl-lin-radeon: diff
  • zww-waves on uberogl-lin-radeon: diff

automated-fifoci-reporter

dolphin-emu-bot avatar Nov 15 '21 00:11 dolphin-emu-bot

FifoCI shouldn't be effected by timing differences at all.

I think there is a bug there

phire avatar Nov 15 '21 14:11 phire

Something else fixed the Datel Products.

JMC47 avatar Aug 16 '22 07:08 JMC47