Olivier Mengué

deps: downgrade objx to v0.5.1

1

## Summary objx `v0.5.2` unnecessarly upgrades the minimum Go version from 1.13 to 1.20. `v0.5.1` is just enough. ## Changes * This reverts commit 814075f391adffd2bf2b5110a74c51827ba132c4 (#1552). ## Motivation objx `v0.5.1`...

Here is a package with similar goals: [`github.com/dolmen-go/flagx`](https://pkg.go.dev/github.com/dolmen-go/flagx).

Tipo in Dockerfile.dapper: DOCKER_CLI_EXPERMENTAL

2

There is a tipo in `Dockerfile.dapper`: `DOCKER_CLI_EXPERMENTAL` instead of `DOCKER_CLI_EXPERIMENTAL`. https://github.com/rancher/dapper/blob/c1e5b08924c6430528141534b704546c755cb8f8/Dockerfile.dapper#L18

@sirupsen @dgsb The issues are stale because there is no active maintainer who looks at them. That isn't a good reason for hiding the reported problems.

Fix references to godoc.org to point instead to pkg.go.dev.

CI: upgrade actions/checkout, actions/setup-go

1

1. Reorder actions to always call [`checkout`](https://github.com/actions/checkout) before [`setup-go`](https://github.com/actions/setup-go) 2. Upgrade `checkout`, `setup-go` to latest See also #1425 which covers the Golangci-lint job.

Fix incorrect usages of the [Testify](https://pkg.go.dev/github.com/stretchr/testify/assert) API, thanks to [testifylint](https://github.com/Antonboom/testifylint) running via golangci-lint. Notes: * Thoses issues are not raised in CI because golangci-lint is [disabled for tests' sources](https://github.com/sirupsen/logrus/blob/dd1b4c2e81afc5c255f216a722b012ed26be57df/.golangci.yml#L3). Of...

Fix incorrect uses of [`math/rand`](https://pkg.go.dev/math/rand): - do not call [`rand.Seed()`](https://pkg.go.dev/math/rand#Seed) (deprecated since Go 1.20) in a test as it affects the global pseudo-random number generator and might affect other tests...

1. upgrade golangci-lint running in GitHub Actions 2. upgrade golangci-lint to v1.56.x Note: issue in package `internal/testutils` reported by testifylint is fixed by #1424

Use `require.NoError(t, err)` instead of `require.Nil(t, err)` as suggested by testifylint. ```console $ golangci-lint version golangci-lint has version 1.56.2 built with go1.22.0 from 58a724a on 2024-02-15T12:52:06Z $ golangci-lint run ./internal/testutils...