Maxim Martynov

Results 137 comments of Maxim Martynov
trafficstars

Or there should be completely new module like `ansible.posix.nfs4_acl` with another set of options, rules and commands being executed.

PR is approved, how about merging?

@samuelcolvin @PrettyWood Could you please yank the 1.10.2 release before this behavior will be fixed?

> This is not a reason to yank anything. Minor release bring up some issues which lead to unexpected failures, this is not a reason? This issue is not connected...

I see here 2 options: 1. Revert https://github.com/pydantic/pydantic/pull/4484. That is not good because this PR resolved other issue which affects other users 2. Create PR which will solve current issue,...

Removing `_extra_dc_args(_cls) == _extra_dc_args(_cls.__bases__[0])` fixes the issue, but fails on [this test](https://github.com/pydantic/pydantic/blob/996101b8bafb5689146d2c3214ebc26d9c9ae1ce/tests/test_dataclasses.py#L1469-L1472) with an error `DataclassProxy.__init__() takes 2 positional argument but 4 were given`. This is caused by wrapping dataclass...

@GeorgianaElena Could you please review?

`modify_pod_hook` hook cannot be used here because it is called before creating the pod, so `owner_reference` cannot be fetched. There could be some new hook after creating a pod, but...

Ok, implemented `after_pod_created_hook` in #644