thermal_comfort icon indicating copy to clipboard operation
thermal_comfort copied to clipboard

Default Sensors for 2.0

Open rautesamtr opened this issue 2 years ago • 4 comments

Since we added a lot of new sensors (We have 13) and also breaking changes this is probably a good time to discuss if we should enable only a subset of them as default. This was brought up before but postponed to a breaking changes release. @dolezsa @IATkachenko

rautesamtr avatar Aug 14 '22 10:08 rautesamtr

@rautesamtr, hello.

I'm not sure that I have enough expertize in this. From my point of view as user, most common sensors should be enabled by default, other -- enabled manually. As the integration is called "Thermal Comfort", then sensors that tell about comfort should be enabled by default and all numeric sensors may be default disabled. Also some numeric sensors may be moved to attributes: for example SIMMER_INDEX my be attribute of SIMMER_ZONE. It will group similar sensors and reduce number of different sensors.

From my point of view as developer, default disabled sensors will not be enabled by 99% of users.

IATkachenko avatar Aug 15 '22 17:08 IATkachenko

I like the idea of moving some numeric values to attributes. At the same time, I wonder if it's right for us to decide which sensors should be the default ones... I'd be more inclined to not have a default then, and force the user to choose what they want to have active.

dolezsa avatar Aug 16 '22 08:08 dolezsa

I opened this discussion in regards to the discussion back on your PR @IATkachenko but since it seems that both of you are leaning more towards not disabling any sensors as default i am board with that.

As regards to moving some values to attributes that would make sense since we are allready doing that for Frost Risk and Scharlau Index. I still would like to keep those values as separate sensors that are meaningfull in their own way e.g. Heat Index, Humidex and Simmer Index which are human readable versions of feels like temperature and one can decide if he prefers the numerical value or a textual describtion or to have both.

rautesamtr avatar Aug 22 '22 14:08 rautesamtr

As regards to moving some values to attributes that would make sense since we are allready doing that for Frost Risk and Scharlau Index. I still would like to keep those values as separate sensors that are meaningfull in their own way e.g. Heat Index, Humidex and Simmer Index which are human readable versions of feels like temperature and one can decide if he prefers the numerical value or a textual describtion or to have both.

Hmm... Looks like this type of sensors may be disabled by default: ordinary user will use text value with digital value in attribute, advanced user will enable digital sensor if needed.

IATkachenko avatar Aug 22 '22 19:08 IATkachenko