dokuwiki
dokuwiki copied to clipboard
dokuwiki
Show old media when viewing old page revision #2048
One possibility of implementing it. Allow wiki admins to change the way how the old revision pages will work.
@solewniczak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akate, @Klap-in and @splitbrain to be potential reviewers.
just a quick note (I have not looked at the code, yet). I don't think this should have a config option. we either decide we want this and make it the default or we don't.
In my opinion, the most intuitive will be showing the old medias but keep the links pointing to the latest pages.
There is also one more thing to concern. It's important to keep in mind that what the "&at=" is actually doing is showing the old revision of page with the media files in the moment of revision creation. What most people may except is showing the old revision of page with the media files in the moment when the actual version becomes an old revision. The picture below shows the problem.
Some thoughts: First of all I don't like the only_media option, I think it's superflous, so I'm not discussing this here.
The real question is: should the list of old revisions pass the revision timestamp as rev or at parameter?
revwill show only the old text of the page, but images will remain currentatwill show the old text as well as the old images (as they were when the page revision was created)
It would be possible to pass not the date of the selected revision, but the date of the next newer revision minus 1 second. This would mitigate the Problem described by @solewniczak
at is basically superior to rev in that it covers more usecases (show old text and show how wiki looked before this change). However at is also slightly more ressource hungry (it needs to look up the correct revision of the page and all media files instead of being able to just load a specific file).
A config option would move the decision to the wiki administrators. But realistically 99.99% of all users would never change whatever we set as default.
Opinions welcome.
That is a curious little problem. Intuitively, I would go with rev, because I'm looking at the old revision of the page after all and media files are not part of the page, only embedded. Though maybe, we can make the at option more prominent somewhere?
That being said, I'm not sure how Mediawiki does it. If I remember it, I'll try it out next week.
MediaWiki always shows the latest. Quick test:
Single instance:
- https://wiki.osmfoundation.org/wiki/File:Maps.me_logo.png
- https://wiki.osmfoundation.org/w/index.php?title=Corporate_Members&direction=next&oldid=6089
Multi instances:
- https://commons.wikimedia.org/wiki/File:1_kawhi_leonard_2019_(cropped).jpg
- https://en.wikipedia.org/w/index.php?title=Kawhi_Leonard&oldid=899755455
I would really like to see this functionality merged. Many wikis use publishing mechanisms (publish or structpublish) and rely on the fact that the content of the published revision does not change.
Although technically media are references and not content, this is not necessarily how users see it. Think of online handbooks or quality management: when I view older revisions of a page, I expect to see the exact charts or screenshots that were rendered when the revision was created.
