ansible-dokku icon indicating copy to clipboard operation
ansible-dokku copied to clipboard

Fix reading existing dokku docker options

Open erikvdv1 opened this issue 2 years ago • 1 comments

The command dokku --quiet docker-options {app} no longer exists, use dokku --quiet docker-options:report {app} instead.

$ dokku --quiet docker-options:report {app}
       Docker options build:          --pull --build-arg test
       Docker options deploy:         --restart=on-failure:10
       Docker options run:

Unfortunately the report command outputs the options on a single line for each type (build, deploy, run). The options type is therefore a string instead of a list.

erikvdv1 avatar Oct 13 '22 14:10 erikvdv1

Hey Erik, just wanted to say thanks for all your contributions; I will try to find some time over the weekend to review them

ltalirz avatar Oct 14 '22 23:10 ltalirz

The command dokku --quiet docker-options {app} no longer exists, use dokku --quiet docker-options:report {app} instead.

@josegonzalez Do you happen to know when this change was made? Just so that we can report the minimal dokku version the role is compatible with.

ltalirz avatar Oct 16 '22 18:10 ltalirz

This was changed in 0.20.0: https://dokku.com/docs/appendices/0.20.0-migration-guide/

josegonzalez avatar Oct 16 '22 18:10 josegonzalez

P.S. Just fixed CI https://github.com/dokku/ansible-dokku/pull/147

ltalirz avatar Oct 16 '22 18:10 ltalirz

You code looks good to me - since I currently don't have a machine to test, would you mind adding a small test somewhere around here

I've added a simple test. 😊

erikvdv1 avatar Oct 16 '22 19:10 erikvdv1