dokku-apt icon indicating copy to clipboard operation
dokku-apt copied to clipboard

Skipping system package installation after dokku-update

Open curvedriver opened this issue 1 year ago • 1 comments

Hi, I used dokku-update and was a little bit confused that dokku-apt uses the old application image.

How I have recognized that? I saw the following message while dokku-update has rebuild my app:

-----> Compatible extended app image found, skipping system package installation

I updated from

  • dokku:0.29.4 to dokku:0.30.2
  • herokuish:0.5.40 to herokuish:0.5.41

My apt-packages file didn't change and it seems that dokku-apt only considers it's own files for the CONTENT_SHA.

  • https://github.com/dokku-community/dokku-apt/blob/3d611d3188c94cae76ef75423f1a972399118446/builder-create-dokku-image#L27

  • https://github.com/dokku-community/dokku-apt/blob/236a9729177bf5f568151bddd0a8e7d42031674c/internal-functions#L22

Is it on purpose, that I have to use docker to delete the cache image manually... or can you suggest a better solution for that issue?

curvedriver avatar Apr 05 '23 11:04 curvedriver

It uses the configured DOKKU_IMAGE as part of it's sha generation, which if you're just using latest, it will appear to never use a newer version. It should probably resolve that image's sha256 digest instead.

Would you be willing to make a PR for this? The code for this would be somewhere around this: https://github.com/dokku-community/dokku-apt/commit/09575a5058443edf25019c5725d0cbcd7ba003d6

josegonzalez avatar May 30 '23 00:05 josegonzalez