doki-theme-jetbrains icon indicating copy to clipboard operation
doki-theme-jetbrains copied to clipboard

Material Icon inconsistency in some JetBrains IDEs

Open justalemon opened this issue 2 years ago • 8 comments

Describe the bug

Using The Doki Theme in different JetBrains IDEs don't show the Material Icons in some IDEs.

So far I was able to reproduce it with WebStorm, Ill test other JetBrains IDEs once I finish my current project.

I installed 84.1-1.2.1 manually from the GitHub Releases page.

To Reproduce

  1. Open a project in a specific IDE
  2. Icons provided by TDT don't show up

Expected Behavior

The same icons appear as the other IDEs.

Environment

WebStorm 2022.1.2 Build #WS-221.5787.30, built on May 31, 2022 Licensed to LemonUI / Hannele Ruiz Subscription is active until May 22, 2023. For non-commercial open source development only. Runtime version: 11.0.15+10-b2043.56 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 10 10.0 GC: G1 Young Generation, G1 Old Generation Memory: 2030M Cores: 4 Non-Bundled Plugins: io.acari.DDLCTheme (84.1-1.2.1) com.almightyalpaca.intellij.plugins.discord (1.9.0)

PyCharm 2022.1.2 (Community Edition) Build #PC-221.5787.24, built on May 31, 2022 Runtime version: 11.0.15+10-b2043.56 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 10 10.0 GC: G1 Young Generation, G1 Old Generation Memory: 1010M Cores: 4 Non-Bundled Plugins: io.acari.DDLCTheme (84.1-1.2.1) com.almightyalpaca.intellij.plugins.discord (1.9.0)

JetBrains Rider 2022.1.1 Build #RD-221.5591.20, built on April 28, 2022 Licensed to LemonUI / Hannele Ruiz Subscription is active until May 22, 2023. For non-commercial open source development only. Runtime version: 11.0.14.1+1-b2043.45 amd64 VM: Dynamic Code Evolution 64-Bit Server VM by JetBrains s.r.o. Windows 10 10.0 .NET Framework (backend unavailable) GC: G1 Young Generation, G1 Old Generation Memory: 1500M Cores: 4 Registry: ide.intellij.laf.enable.animation=true ide.new.project.model.index.case.sensitivity=true rdclient.asyncActions=false indexing.enable.entity.provider.based.indexing=false

Non-Bundled Plugins: io.acari.DDLCTheme (84.1-1.2.1) com.almightyalpaca.intellij.plugins.discord (1.9.0)

Screenshots

Please note that the exact same project was open in all screenshots.

Webstorm:

image

PyCharm Community:

image

Rider:

image

justalemon avatar Jun 07 '22 22:06 justalemon

Is the expected result that you see the same icons in Pycharm?

I'm assuming you have the Doki Material Icons enabled?

Unthrottled avatar Jun 07 '22 23:06 Unthrottled

Is the expected result that you see the same icons in Pycharm?

On PyCharm and Rider I see the Material Icons, yes.

I'm assuming you have the Doki Material Icons enabled?

Correct.

justalemon avatar Jun 08 '22 00:06 justalemon

Aight, I'll eventually take a look at it. I'm less inclined to fix this issue, because I don't use this feature, and have been wanting to remove it for a while now.

Unthrottled avatar Jun 08 '22 10:06 Unthrottled

I think what I am going to end up doing is making my own icons.

I'll get rid of the Material icons, and migrate users that where using to use the Doki Icons.

Unthrottled avatar Jun 26 '22 23:06 Unthrottled

Hey! Are you still using this feature? (Do you still care?)

Been spending the last month or so building icons. I'll be removing all of the material icons. So trying to figure out how many icon's I'll need to make & patch for MVP. (So I can get out of Icon Hell)

If I don't hear anything by end of September, I'll take it as a nope.

Unthrottled avatar Sep 16 '22 23:09 Unthrottled

I'm still using the icons, yeah.

It was mostly about the inconsistency of the icons between the different IDEs, as I sometimes have multiple Jetbrains IDEs open side by side at once.

justalemon avatar Sep 17 '22 11:09 justalemon

Got it, thanks!

I'm currently not planning on having the named folders (the special icons for folders like node_modules, .github, etc) as part of the initial release, I might consider it later. There will be some support for the named icons (eg. package-lock.json, LICENSE, etc). And a brand new set of UI icons.

What I disliked about keeping the material theme icons (from a long time ago) is that they don't feel like they are color consistent with my themes. I'm going to fix that with my set of icons. Hopefully a better color palette will make up for a lack of features pre-existing features.

Unthrottled avatar Sep 17 '22 12:09 Unthrottled

eg. package-lock.json, LICENSE, etc

There is a bit of a collision when something is called LICENSE.* (in my case, license.sql) where it shows the copyright icon instead of the SQL icon. I don't know if is possible to tweak the priority of the icons but should probably take a look, and if possible make it configurable.

justalemon avatar Sep 17 '22 12:09 justalemon

Hey, figured I'd give a status update. I'm still working through adding more icons and stuff. Currently working through defining the color palette. Still plenty of work for me to do still.

However I just got to Cinnamon, and figured I'd share the general vibe the new icon set is going to have. Screen Shot 2022-10-20 at 6 04 28 PM

Unthrottled avatar Oct 20 '22 23:10 Unthrottled

That looks pretty cool!

I guess that the icon color is dependent on the theme selected, right?

Also, will the icons be supported on other IDEs and Code Editors that support custom icons?

justalemon avatar Oct 21 '22 23:10 justalemon

I guess that the icon color is dependent on the theme selected, right?

The icon theme is independent of the theme selected. However the default option is to have the icon theme automatically match the current UI theme.

For example, it is possible to put Megumin's icon them when using Aqua

Megumin Aqua
Screen Shot 2022-10-21 at 6 55 04 PM Screen Shot 2022-10-21 at 6 54 47 PM

Aqua UI Theme & Megumin Icon Theme Screen Shot 2022-10-21 at 6 55 59 PM

Also, will the icons be supported on other IDEs and Code Editors that support custom icons?

The initial MVP will to support all JetBrains IDEs. I won't have all the icon's replaced, but a large majority should be replaced.

Once I get that done I'll eventually look into supporting other platforms. However, I plan on taking a break after getting the JetBrains icons done.

Unthrottled avatar Oct 22 '22 00:10 Unthrottled

As a FYI, I haven't completely gotten all icons replaced. Just looking at all the icons they provide makes me want to bury my head in sand.

Am currently working on trying to get a beta version of the icon plugin released. https://github.com/doki-theme/doki-theme-icons-jetbrains

Unthrottled avatar Nov 06 '22 23:11 Unthrottled